]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
idmap: Make pointer initialization explicit
authorVolker Lendecke <vl@samba.org>
Wed, 25 Jul 2018 10:05:58 +0000 (12:05 +0200)
committerJeremy Allison <jra@samba.org>
Thu, 26 Jul 2018 20:44:24 +0000 (22:44 +0200)
Took me a few seconds to find this NULL initializer

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/winbindd/idmap_tdb_common.c

index 48d87bb16cf17d9b7043571deaee632ef53a8914..ceb663c0ddd889dcd6457f9e09025a7998c2aaa5 100644 (file)
@@ -221,14 +221,13 @@ NTSTATUS idmap_tdb_common_set_mapping(struct idmap_domain * dom,
        struct idmap_tdb_common_context *ctx;
        struct idmap_tdb_common_set_mapping_context state;
        NTSTATUS ret;
-       char *ksidstr, *kidstr;
+       char *ksidstr = NULL;
+       char *kidstr = NULL;
 
        if (!map || !map->sid) {
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       ksidstr = kidstr = NULL;
-
        /* TODO: should we filter a set_mapping using low/high filters ? */
 
        ctx =