]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net/mlx5e: Use tcp_v[46]_check checksum helpers
authorGal Pressman <gal@nvidia.com>
Thu, 13 Jun 2024 21:00:35 +0000 (00:00 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 15 Jun 2024 01:53:24 +0000 (18:53 -0700)
Use the tcp specific helpers to calculate the tcp pseudo header checksum
instead of the csum_*_magic ones.

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20240613210036.1125203-6-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c

index 43f018567fafc047424f5c44d98292b99dc7c40f..225da8d691fcf25a236bcd7c98fc351f86c2d566 100644 (file)
@@ -1182,9 +1182,8 @@ static void mlx5e_lro_update_hdr(struct sk_buff *skb, struct mlx5_cqe64 *cqe,
                check = csum_partial(tcp, tcp->doff * 4,
                                     csum_unfold((__force __sum16)cqe->check_sum));
                /* Almost done, don't forget the pseudo header */
-               tcp->check = csum_tcpudp_magic(ipv4->saddr, ipv4->daddr,
-                                              tot_len - sizeof(struct iphdr),
-                                              IPPROTO_TCP, check);
+               tcp->check = tcp_v4_check(tot_len - sizeof(struct iphdr),
+                                         ipv4->saddr, ipv4->daddr, check);
        } else {
                u16 payload_len = tot_len - sizeof(struct ipv6hdr);
                struct ipv6hdr *ipv6 = ip_p;
@@ -1199,8 +1198,8 @@ static void mlx5e_lro_update_hdr(struct sk_buff *skb, struct mlx5_cqe64 *cqe,
                check = csum_partial(tcp, tcp->doff * 4,
                                     csum_unfold((__force __sum16)cqe->check_sum));
                /* Almost done, don't forget the pseudo header */
-               tcp->check = csum_ipv6_magic(&ipv6->saddr, &ipv6->daddr, payload_len,
-                                            IPPROTO_TCP, check);
+               tcp->check = tcp_v6_check(payload_len, &ipv6->saddr,
+                                         &ipv6->daddr, check);
        }
 }