]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
upstream: Provide defaults for ciphers and macs
authordtucker@openbsd.org <dtucker@openbsd.org>
Wed, 19 Jun 2024 10:15:51 +0000 (10:15 +0000)
committerDarren Tucker <dtucker@dtucker.net>
Wed, 19 Jun 2024 10:36:57 +0000 (20:36 +1000)
if querying for them fails since on some versions of Dropbear (at least
v2024.85) "-m help" doesn't seem to work.  Enable all supported pubkey
algorithms in the server.

OpenBSD-Regress-ID: 4f95556a49ee9f621789f25217c367a33d2745ca

regress/dropbear-ciphers.sh

index 2e0f9a1d337f6d1935945b688d0d3f69ed34af3d..7b0924ce7a0b3dcdcb7872ff003d0ecf46bee5d9 100644 (file)
@@ -1,4 +1,4 @@
-#      $OpenBSD: dropbear-ciphers.sh,v 1.1 2023/10/20 06:56:45 dtucker Exp $
+#      $OpenBSD: dropbear-ciphers.sh,v 1.2 2024/06/19 10:15:51 dtucker Exp $
 #      Placed in the Public Domain.
 
 tid="dropbear ciphers"
@@ -7,13 +7,23 @@ if test "x$REGRESS_INTEROP_DROPBEAR" != "xyes" ; then
        skip "dropbear interop tests not enabled"
 fi
 
+# Enable all support algorithms
+algs=`$SSH -Q key-sig | tr '\n' ,`
 cat >>$OBJ/sshd_proxy <<EOD
-PubkeyAcceptedAlgorithms +ssh-rsa,ssh-dss
-HostkeyAlgorithms +ssh-rsa,ssh-dss
+PubkeyAcceptedAlgorithms $algs
+HostkeyAlgorithms $algs
 EOD
 
 ciphers=`$DBCLIENT -c help 2>&1 | awk '/ ciphers: /{print $4}' | tr ',' ' '`
+if [ -z "$ciphers" ]; then
+       trace dbclient query ciphers failed, making assumptions.
+       ciphers="chacha20-poly1305@openssh.com aes128-ctr aes256-ctr"
+fi
 macs=`$DBCLIENT -m help 2>&1 | awk '/ MACs: /{print $4}' | tr ',' ' '`
+if [ -z "$macs" ]; then
+       trace dbclient query macs failed, making assumptions.
+       macs="hmac-sha1 hmac-sha2-256"
+fi
 keytype=`(cd $OBJ/.dropbear && ls id_*)`
 
 for c in $ciphers ; do