]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MEDIUM: mworker: does not deinit anymore
authorWilliam Lallemand <wlallemand@haproxy.com>
Wed, 15 Nov 2017 18:02:57 +0000 (19:02 +0100)
committerWilly Tarreau <w@1wt.eu>
Wed, 15 Nov 2017 18:53:31 +0000 (19:53 +0100)
Does not use the deinit() function during a reload, it's dangerous and
might be subject to double free, segfault and hazardous behavior if
it's called twice in the case of a execvp fail.

src/haproxy.c

index b90e2540ba9b48e6e51d8e6d851c6cc06660cdfb..00cc25b165a220916eac201fc12188aa129195d4 100644 (file)
@@ -648,7 +648,6 @@ static void mworker_reload()
                next_argv[next_argc++] = NULL;
        }
 
-       deinit(); /* we don't want to leak FD there */
        Warning("Reexecuting Master process\n");
        execvp(next_argv[0], next_argv);