]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib: net_ip2addr() - Optimize by allocating destination memory immediately
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Fri, 3 Nov 2017 23:42:37 +0000 (01:42 +0200)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Tue, 7 Nov 2017 19:22:06 +0000 (21:22 +0200)
It doesn't really matter if we allocate a few extra bytes.

src/lib/net.c

index cd414113df09fbbbbb661db53353204a96abe66b..2facbd97d71f636a25be42a49b0e29a25990b139 100644 (file)
@@ -931,13 +931,12 @@ int net_getunixcred(int fd, struct net_unix_cred *cred_r)
 const char *net_ip2addr(const struct ip_addr *ip)
 {
 #ifdef HAVE_IPV6
-       char addr[MAX_IP_LEN+1];
+       char *addr = t_malloc(MAX_IP_LEN+1);
 
-       addr[MAX_IP_LEN] = '\0';
        if (inet_ntop(ip->family, &ip->u.ip6, addr, MAX_IP_LEN) == NULL)
                return "";
 
-       return t_strdup(addr);
+       return addr;
 #else
        unsigned long ip4;