auth: Fix getTSIGKeys() return value in GSQL and LMDB backends

These Bind and remote backends return true when at least a TSIG key
is returned, as expected by the API and pdnsutil code, but the GSQL
backend returned false if at least a key was returned and true
otherwise. The LMDB backend always returned false.
This caused `pdnsutil b2b-migrate` not to migrate TSIG keys from a
GSQL or LMDB backend, amongst other things.

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index e287a0b892390c00068faaf319e76645b6fa7f07..92dbb97293369f0abafde474f55cef22b04fd1cd 100644 (file)
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1745,7 +1745,7 @@ bool LMDBBackend::getTSIGKeys(std::vector<struct TSIGKey>& keys)
   for (auto iter = txn.begin(); iter != txn.end(); ++iter) {
     keys.push_back(*iter);
   }
-  return false;
+  return !keys.empty();
 }
 
 class LMDBFactory : public BackendFactory

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index dc9a31947848428a011797fe2396179f1b107597..ab8ef9f5b074dfecfc7f8d9641184d7eb1edbb85 100644 (file)
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -976,7 +976,7 @@ bool GSQLBackend::getTSIGKeys(std::vector< struct TSIGKey > &keys)
     throw PDNSException("GSQLBackend unable to retrieve TSIG keys: "+e.txtReason());
   }
 
-  return keys.empty();
+  return !keys.empty();
 }
 
 bool GSQLBackend::getDomainKeys(const DNSName& name, std::vector<KeyData>& keys)