]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe/gsc: Make GSCCS disabling message less alarming
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Thu, 19 Dec 2024 01:09:24 +0000 (17:09 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Fri, 20 Dec 2024 19:17:44 +0000 (14:17 -0500)
The GSCCS is only used to transport messages from the driver to the GSC
FW; therefore, we can disable it if we're not using the FW, which is
the case on both BMG and PTL. However, the current wording of the logged
message could be interpreted as a problem, so reword to make it clearer
it is not an error and lower it debug verbosity as users don't really
need to know about it.

Reported-by: Eero Tamminen <eero.t.tamminen@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3866
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241219010924.2466333-1-daniele.ceraolospurio@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_hw_engine.c

index 4294aa600192d00b759030576c130d8be0451563..ac9c666a9652a4f0362637d8e3adf3c160960a0f 100644 (file)
@@ -775,7 +775,7 @@ static void check_gsc_availability(struct xe_gt *gt)
                xe_mmio_write32(&gt->mmio, GUNIT_GSC_INTR_ENABLE, 0);
                xe_mmio_write32(&gt->mmio, GUNIT_GSC_INTR_MASK, ~0);
 
-               drm_info(&xe->drm, "gsccs disabled due to lack of FW\n");
+               drm_dbg(&xe->drm, "GSC FW not used, disabling gsccs\n");
        }
 }