Fix assert() with side effects

assert() may be completely removed by precompiler when optimizing. Such
that the code conditional never gets run.

diff --git a/src/HttpRequest.cc b/src/HttpRequest.cc
index bfb6e571ea000d44213a0a0a8539f6cb2e806e4e..036080781589803bec4cb7d94194d694d01325cc 100644 (file)
--- a/src/HttpRequest.cc
+++ b/src/HttpRequest.cc
@@ -234,7 +234,8 @@ HttpRequest::clone() const
     copy->extacl_log = extacl_log;
     copy->extacl_message = extacl_message;
 
-    assert(copy->inheritProperties(this));
+    const bool inheritWorked = copy->inheritProperties(this);
+    assert(inheritWorked);
 
     return copy;
 }