]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: samsung-dsim: use dynamic lifetime management
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Wed, 26 Mar 2025 17:47:39 +0000 (18:47 +0100)
committerLouis Chauvet <louis.chauvet@bootlin.com>
Mon, 7 Apr 2025 09:38:06 +0000 (11:38 +0200)
Allow this bridge to be removable without dangling pointers and
use-after-free, together with proper use of drm_bridge_get() and _put() by
consumers.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250326-drm-bridge-refcount-v9-5-5e0661fe1f84@bootlin.com
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
drivers/gpu/drm/bridge/samsung-dsim.c

index 55ac6bd5da08c037aa7974df679d51e72bc54faf..0014c497e3fe7d8349a119dbdda30d65d816cccf 100644 (file)
@@ -1936,9 +1936,9 @@ int samsung_dsim_probe(struct platform_device *pdev)
        struct samsung_dsim *dsi;
        int ret, i;
 
-       dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
-       if (!dsi)
-               return -ENOMEM;
+       dsi = devm_drm_bridge_alloc(dev, struct samsung_dsim, bridge, &samsung_dsim_bridge_funcs);
+       if (IS_ERR(dsi))
+               return PTR_ERR(dsi);
 
        init_completion(&dsi->completed);
        spin_lock_init(&dsi->transfer_lock);
@@ -2008,7 +2008,6 @@ int samsung_dsim_probe(struct platform_device *pdev)
 
        pm_runtime_enable(dev);
 
-       dsi->bridge.funcs = &samsung_dsim_bridge_funcs;
        dsi->bridge.of_node = dev->of_node;
        dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;