]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:lib: Initialize pointer to NULL
authorJennifer Sutton <jennifersutton@catalyst.net.nz>
Thu, 20 Feb 2025 02:05:42 +0000 (15:05 +1300)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 27 Aug 2025 03:41:36 +0000 (03:41 +0000)
../../source3/lib/netapi/tests/netdisplay.c: In function ‘test_netquerydisplayinformation’:
../../source3/lib/netapi/tests/netdisplay.c:87:45: error: ‘current_name’ may be used uninitialized [-Werror=maybe-uninitialized]
   87 |                                 if (name && strcasecmp(current_name, name) == 0) {
      |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../source3/lib/netapi/tests/netdisplay.c:37:21: note: ‘current_name’ was declared here
   37 |         const char *current_name;
      |                     ^~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
source3/lib/netapi/tests/netdisplay.c

index d7967fa4150189c7898629f8a514402ac975539b..e1078e1daad643499fb04fe1c1eb632a4507cf91 100644 (file)
@@ -34,7 +34,7 @@ static NET_API_STATUS test_netquerydisplayinformation(const char *hostname,
        NET_API_STATUS status;
        uint32_t entries_read = 0;
        int found_name = 0;
-       const char *current_name;
+       const char *current_name = NULL;
        uint8_t *buffer = NULL;
        uint32_t idx = 0;
        int i;