]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf amd ibs: Incorporate Zen5 DTLB and PageSize information
authorRavi Bangoria <ravi.bangoria@amd.com>
Tue, 29 Apr 2025 03:59:36 +0000 (03:59 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 30 Apr 2025 01:30:46 +0000 (22:30 -0300)
IBS Op PMU on Zen5 reports DTLB and page size information differently
compared to prior generation.

  IBS_OP_DATA3     Zen3/4                 Zen5
  ----------------------------------------------------------------
  19               IbsDcL2TlbHit1G        Reserved
  ----------------------------------------------------------------
   6               IbsDcL2tlbHit2M        Reserved
  ----------------------------------------------------------------
   5               IbsDcL1TlbHit1G        PageSize:
   4               IbsDcL1TlbHit2M          0 - 4K
                                            1 - 2M
                                            2 - 1G
                                            3 - Reserved
                                          Valid only if
                                            IbsDcPhyAddrValid = 1
  ----------------------------------------------------------------
   3               IbsDcL2TlbMiss         IbsDcL2TlbMiss
                                          Valid only if
                                            IbsDcPhyAddrValid = 1
  ----------------------------------------------------------------
   2               IbsDcL1tlbMiss         IbsDcL1tlbMiss
                                          Valid only if
                                            IbsDcPhyAddrValid = 1
  ----------------------------------------------------------------

Kernel expose this change as "dtlb_pgsize" capability in PMU sysfs.

Change IBS register raw-dump logic according to new bit definitions.

Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Ananth Narayan <ananth.narayan@amd.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Mario <jmario@redhat.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Santosh Shukla <santosh.shukla@amd.com>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20250429035938.1301-3-ravi.bangoria@amd.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/amd-sample-raw.c

index ac34b18ccc0c1f91f10f3c163b533686fe3d9b08..022c9eb3950909226ea273a564137aa41460ed37 100644 (file)
@@ -20,6 +20,7 @@
 static u32 cpu_family, cpu_model, ibs_fetch_type, ibs_op_type;
 static bool zen4_ibs_extensions;
 static bool ldlat_cap;
+static bool dtlb_pgsize_cap;
 
 static void pr_ibs_fetch_ctl(union ibs_fetch_ctl reg)
 {
@@ -161,9 +162,20 @@ static void pr_ibs_op_data2(union ibs_op_data2 reg)
 
 static void pr_ibs_op_data3(union ibs_op_data3 reg)
 {
-       char l2_miss_str[sizeof(" L2Miss _")] = "";
-       char op_mem_width_str[sizeof(" OpMemWidth _____ bytes")] = "";
+       static const char * const dc_page_sizes[] = {
+               "  4K",
+               "  2M",
+               "  1G",
+               "  ??",
+       };
        char op_dc_miss_open_mem_reqs_str[sizeof(" OpDcMissOpenMemReqs __")] = "";
+       char dc_l1_l2tlb_miss_str[sizeof(" DcL1TlbMiss _ DcL2TlbMiss _")] = "";
+       char dc_l1tlb_hit_str[sizeof(" DcL1TlbHit2M _ DcL1TlbHit1G _")] = "";
+       char op_mem_width_str[sizeof(" OpMemWidth _____ bytes")] = "";
+       char dc_l2tlb_hit_2m_str[sizeof(" DcL2TlbHit2M _")] = "";
+       char dc_l2tlb_hit_1g_str[sizeof(" DcL2TlbHit1G _")] = "";
+       char dc_page_size_str[sizeof(" DcPageSize ____")] = "";
+       char l2_miss_str[sizeof(" L2Miss _")] = "";
 
        /*
         * Erratum #1293
@@ -179,16 +191,40 @@ static void pr_ibs_op_data3(union ibs_op_data3 reg)
                snprintf(op_mem_width_str, sizeof(op_mem_width_str),
                         " OpMemWidth %2d bytes", 1 << (reg.op_mem_width - 1));
 
-       printf("ibs_op_data3:\t%016llx LdOp %d StOp %d DcL1TlbMiss %d DcL2TlbMiss %d "
-               "DcL1TlbHit2M %d DcL1TlbHit1G %d DcL2TlbHit2M %d DcMiss %d DcMisAcc %d "
-               "DcWcMemAcc %d DcUcMemAcc %d DcLockedOp %d DcMissNoMabAlloc %d DcLinAddrValid %d "
-               "DcPhyAddrValid %d DcL2TlbHit1G %d%s SwPf %d%s%s DcMissLat %5d TlbRefillLat %5d\n",
-               reg.val, reg.ld_op, reg.st_op, reg.dc_l1tlb_miss, reg.dc_l2tlb_miss,
-               reg.dc_l1tlb_hit_2m, reg.dc_l1tlb_hit_1g, reg.dc_l2tlb_hit_2m, reg.dc_miss,
-               reg.dc_mis_acc, reg.dc_wc_mem_acc, reg.dc_uc_mem_acc, reg.dc_locked_op,
-               reg.dc_miss_no_mab_alloc, reg.dc_lin_addr_valid, reg.dc_phy_addr_valid,
-               reg.dc_l2_tlb_hit_1g, l2_miss_str, reg.sw_pf, op_mem_width_str,
-               op_dc_miss_open_mem_reqs_str, reg.dc_miss_lat, reg.tlb_refill_lat);
+       if (dtlb_pgsize_cap) {
+               if (reg.dc_phy_addr_valid) {
+                       int idx = (reg.dc_l1tlb_hit_1g << 1) | reg.dc_l1tlb_hit_2m;
+
+                       snprintf(dc_l1_l2tlb_miss_str, sizeof(dc_l1_l2tlb_miss_str),
+                                " DcL1TlbMiss %d DcL2TlbMiss %d",
+                                reg.dc_l1tlb_miss, reg.dc_l2tlb_miss);
+                       snprintf(dc_page_size_str, sizeof(dc_page_size_str),
+                                " DcPageSize %4s", dc_page_sizes[idx]);
+               }
+       } else {
+               snprintf(dc_l1_l2tlb_miss_str, sizeof(dc_l1_l2tlb_miss_str),
+                        " DcL1TlbMiss %d DcL2TlbMiss %d",
+                        reg.dc_l1tlb_miss, reg.dc_l2tlb_miss);
+               snprintf(dc_l1tlb_hit_str, sizeof(dc_l1tlb_hit_str),
+                        " DcL1TlbHit2M %d DcL1TlbHit1G %d",
+                        reg.dc_l1tlb_hit_2m, reg.dc_l1tlb_hit_1g);
+               snprintf(dc_l2tlb_hit_2m_str, sizeof(dc_l2tlb_hit_2m_str),
+                        " DcL2TlbHit2M %d", reg.dc_l2tlb_hit_2m);
+               snprintf(dc_l2tlb_hit_1g_str, sizeof(dc_l2tlb_hit_1g_str),
+                        " DcL2TlbHit1G %d", reg.dc_l2_tlb_hit_1g);
+       }
+
+       printf("ibs_op_data3:\t%016llx LdOp %d StOp %d%s%s%s DcMiss %d DcMisAcc %d "
+               "DcWcMemAcc %d DcUcMemAcc %d DcLockedOp %d DcMissNoMabAlloc %d "
+               "DcLinAddrValid %d DcPhyAddrValid %d%s%s SwPf %d%s%s "
+               "DcMissLat %5d TlbRefillLat %5d\n",
+               reg.val, reg.ld_op, reg.st_op, dc_l1_l2tlb_miss_str,
+               dtlb_pgsize_cap ? dc_page_size_str : dc_l1tlb_hit_str,
+               dc_l2tlb_hit_2m_str, reg.dc_miss, reg.dc_mis_acc, reg.dc_wc_mem_acc,
+               reg.dc_uc_mem_acc, reg.dc_locked_op, reg.dc_miss_no_mab_alloc,
+               reg.dc_lin_addr_valid, reg.dc_phy_addr_valid, dc_l2tlb_hit_1g_str,
+               l2_miss_str, reg.sw_pf, op_mem_width_str, op_dc_miss_open_mem_reqs_str,
+               reg.dc_miss_lat, reg.tlb_refill_lat);
 }
 
 /*
@@ -341,6 +377,9 @@ bool evlist__has_amd_ibs(struct evlist *evlist)
        if (perf_env__find_pmu_cap(env, "ibs_op", "ldlat"))
                ldlat_cap = 1;
 
+       if (perf_env__find_pmu_cap(env, "ibs_op", "dtlb_pgsize"))
+               dtlb_pgsize_cap = 1;
+
        if (ibs_fetch_type || ibs_op_type) {
                if (!cpu_family)
                        parse_cpuid(env);