]> git.ipfire.org Git - people/ms/suricata.git/commitdiff
app-layer-ssl: fix JA3 bug in TLS extension decoding
authorMats Klepsland <mats.klepsland@gmail.com>
Fri, 19 Oct 2018 21:00:42 +0000 (23:00 +0200)
committerVictor Julien <victor@inliniac.net>
Mon, 22 Oct 2018 08:41:27 +0000 (10:41 +0200)
src/app-layer-ssl.c

index 6c823da8c037e0488b76ce43eac3132253cbc1b5..d0c99b69b97df7609dc84d0f748ae50f3a396361 100644 (file)
@@ -1197,6 +1197,7 @@ static inline int TLSDecodeHSHelloExtensions(SSLState *ssl_state,
             }
         }
 
+next:
         if ((ssl_state->current_flags & SSL_AL_FLAG_STATE_CLIENT_HELLO) &&
                 ssl_config.enable_ja3) {
             if (TLSDecodeValueIsGREASE(ext_type) != 1) {
@@ -1206,7 +1207,6 @@ static inline int TLSDecodeHSHelloExtensions(SSLState *ssl_state,
             }
         }
 
-next:
         processed_len += ext_len + 4;
     }