]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfp: flower: use vmalloc_array() to simplify code
authorQianfeng Rong <rongqianfeng@vivo.com>
Sat, 16 Aug 2025 09:06:53 +0000 (17:06 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Aug 2025 00:49:51 +0000 (17:49 -0700)
Remove array_size() calls and replace vmalloc() with vmalloc_array() in
nfp_flower_metadata_init().  vmalloc_array() is also optimized better,
resulting in less instructions being used.

Place 'NFP_FL_STATS_ELEM_RS' with the sizeof() parameter as the second
argument to vmalloc_array() to avoid -Wcalloc-transposed-args compilation
warnings.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Link: https://patch.msgid.link/20250816090659.117699-3-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/netronome/nfp/flower/metadata.c

index 80e4675582bfbab6ea407d30db909905f6381196..dde60c4572fa251d4d2a1a93b0d1b7f33ea4af4a 100644 (file)
@@ -564,8 +564,8 @@ int nfp_flower_metadata_init(struct nfp_app *app, u64 host_ctx_count,
 
        /* Init ring buffer and unallocated stats_ids. */
        priv->stats_ids.free_list.buf =
-               vmalloc(array_size(NFP_FL_STATS_ELEM_RS,
-                                  priv->stats_ring_size));
+               vmalloc_array(priv->stats_ring_size,
+                             NFP_FL_STATS_ELEM_RS);
        if (!priv->stats_ids.free_list.buf)
                goto err_free_last_used;