]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
avoid fd leak
authorWen Congyang <wency@cn.fujitsu.com>
Wed, 30 May 2012 09:20:46 +0000 (17:20 +0800)
committerCole Robinson <crobinso@redhat.com>
Fri, 15 Jun 2012 14:58:24 +0000 (10:58 -0400)
virCommandRunAsync() will set errfd if it succeed. We should
close it if virFDStreamOpenInternal() fails.
(cherry picked from commit 655cffa0f25be40c68624036af80bde102177612)

src/fdstream.c

index f61ec0905306d7ebcb2c6061d42c48cce943e3f4..91942a874bb61a576cc18d0aefcb9cd6c5b8981c 100644 (file)
@@ -664,6 +664,7 @@ error:
     VIR_FORCE_CLOSE(fds[0]);
     VIR_FORCE_CLOSE(fds[1]);
     VIR_FORCE_CLOSE(fd);
+    VIR_FORCE_CLOSE(errfd);
     if (oflags & O_CREAT)
         unlink(path);
     return -1;