]> git.ipfire.org Git - thirdparty/git.git/commitdiff
merge-ort: fix missing early return
authorElijah Newren <newren@gmail.com>
Thu, 4 Jul 2024 20:02:21 +0000 (20:02 +0000)
committerJunio C Hamano <gitster@pobox.com>
Sat, 6 Jul 2024 17:47:00 +0000 (10:47 -0700)
One of the conversions in f19b9165 (merge-ort: convert more error()
cases to path_msg(), 2024-06-19) accidentally lost the early return.

Restore it.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-ort.c

index 8dfe80f100914f572b270ec4c5280fd5ea64ae3a..d9ba6e3e52348948eef64f7f25e81dd0e05752ad 100644 (file)
@@ -3618,6 +3618,7 @@ static int read_oid_strbuf(struct merge_options *opt,
                path_msg(opt, ERROR_OBJECT_NOT_A_BLOB, 0,
                         path, NULL, NULL, NULL,
                         _("error: object %s is not a blob"), oid_to_hex(oid));
+               return -1;
        }
        strbuf_attach(dst, buf, size, size + 1);
        return 0;