]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
fs/direct-io: remove redundant assignment to variable retval
authorColin Ian King <colin.i.king@gmail.com>
Wed, 10 Apr 2024 16:22:21 +0000 (17:22 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 11 Apr 2024 08:21:24 +0000 (10:21 +0200)
The variable retval is being assigned a value that is not being read,
it is being re-assigned later on in the function. The assignment
is redundant and can be removed.

Cleans up clang scan build warning:
fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240410162221.292485-1-colin.i.king@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/direct-io.c

index 62c97ff9e852a15b495b1bdb3790290dddc33515..b0aafe640fa4286d3f2fb64a56578b8c4d53a8b1 100644 (file)
@@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
         */
        inode_dio_begin(inode);
 
-       retval = 0;
        sdio.blkbits = blkbits;
        sdio.blkfactor = i_blkbits - blkbits;
        sdio.block_in_file = offset >> blkbits;