selftests/efivarfs: fix tests for failed write removal

The current self tests expect the zero size remnants that failed
variable creation leaves.  Update the tests to verify these are now
absent.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

diff --git a/tools/testing/selftests/efivarfs/efivarfs.sh b/tools/testing/selftests/efivarfs/efivarfs.sh
index 96677282789b1bbac0a7a4457024657e49b53fe2..4a84a810dc2cf7e83779b7840190608dd4b1c332 100755 (executable)
--- a/tools/testing/selftests/efivarfs/efivarfs.sh
+++ b/tools/testing/selftests/efivarfs/efivarfs.sh
@@ -76,11 +76,11 @@ test_create_empty()
 
        : > $file
 
-       if [ ! -e $file ]; then
-               echo "$file can not be created without writing" >&2
+       if [ -e $file ]; then
+               echo "$file can be created without writing" >&2
+               file_cleanup $file
                exit 1
        fi
-       file_cleanup $file
 }
 
 test_create_read()
@@ -89,10 +89,13 @@ test_create_read()
        ./create-read $file
        if [ $? -ne 0 ]; then
                echo "create and read $file failed"
+               exit 1
+       fi
+       if [ -e $file ]; then
+               echo "file still exists and should not"
                file_cleanup $file
                exit 1
        fi
-       file_cleanup $file
 }
 
 test_delete()