]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netxen_nic: Mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 7 Aug 2018 23:26:49 +0000 (18:26 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Aug 2018 00:54:20 +0000 (17:54 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1410182 ("Missing break in switch")
Addresses-Coverity-ID: 1410183 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c

index 3157f97dd782b8357cc79cc18f809b07deda1cb2..3c1be87cdfa576b087cf6978dc0740b5fc453de8 100644 (file)
@@ -167,9 +167,9 @@ skip:
        case NETXEN_BRDTYPE_P3_REF_QG:
        case NETXEN_BRDTYPE_P3_4_GB:
        case NETXEN_BRDTYPE_P3_4_GB_MM:
-
                supported |= SUPPORTED_Autoneg;
                advertising |= ADVERTISED_Autoneg;
+               /* fall through */
        case NETXEN_BRDTYPE_P2_SB31_10G_CX4:
        case NETXEN_BRDTYPE_P3_10G_CX4:
        case NETXEN_BRDTYPE_P3_10G_CX4_LP:
@@ -198,6 +198,7 @@ skip:
                supported |= SUPPORTED_TP;
                check_sfp_module = netif_running(dev) &&
                        adapter->has_link_events;
+               /* fall through */
        case NETXEN_BRDTYPE_P2_SB31_10G:
        case NETXEN_BRDTYPE_P3_10G_XFP:
                supported |= SUPPORTED_FIBRE;