TODOs: Reprioritize

There were a lot of FIXMEs that were minor nice-to-haves at best.

diff --git a/src/asn1/asn1c/INTEGER.c b/src/asn1/asn1c/INTEGER.c
index d64c458e6098a20e65142ffe2708f65a556b2b79..919ef7d174cba2a9674dae93b19bb02c416a7394 100644 (file)
--- a/src/asn1/asn1c/INTEGER.c
+++ b/src/asn1/asn1c/INTEGER.c
@@ -870,7 +870,7 @@ asn_INTEGER2imax(const INTEGER_t *iptr, intmax_t *lptr) {
        return 0;
 }
 
-/* FIXME: negative INTEGER values are silently interpreted as large unsigned ones. */
+/* TODO (asn1c) negative INTEGER values are silently interpreted as large unsigned ones. */
 int
 asn_INTEGER2umax(const INTEGER_t *iptr, uintmax_t *lptr) {
        uint8_t *b, *end;

diff --git a/src/asn1/asn1c/ber_decoder.c b/src/asn1/asn1c/ber_decoder.c
index 4dcf78b05688ecbb0018f5e453743bea34dcfbab..6cbcb8a3dcd09106597faf247ffe9204d616bb8f 100644 (file)
--- a/src/asn1/asn1c/ber_decoder.c
+++ b/src/asn1/asn1c/ber_decoder.c
@@ -213,11 +213,9 @@ ber_check_tags(const asn_codec_ctx_t *opt_codec_ctx,
                }
 
                /*
-                * FIXME
-                * As of today, the chain of tags
-                * must either contain several indefinite length TLVs,
-                * or several definite length ones.
-                * No mixing is allowed.
+                * TODO (fine) As of today, the chain of tags must either
+                * contain several indefinite length TLVs, or several definite
+                * length ones. No mixing is allowed.
                 */
                if(tlv_len == -1) {
                        /*

diff --git a/src/asn1/decode.c b/src/asn1/decode.c
index f4703d1d1b13819720b67aa5a506183f5f9b55a9..a7652946c6ee7883436d0ae8401b970a15bbbb2a 100644 (file)
--- a/src/asn1/decode.c
+++ b/src/asn1/decode.c
@@ -52,7 +52,7 @@ der_coder(const void *buf, size_t size, void *app_key)
 }
 
 /*
- * FIXME (next iteration) This isn't efficient, consider implement DER decoding
+ * TODO (performance) This isn't efficient, consider implement DER decoding
  * or something better.
  */
 static int

diff --git a/src/asn1/oid.c b/src/asn1/oid.c
index d7018d31b38871a9afd6ec5881b1db56d1300cb5..6f4043d819c6436073f2cfca5406ade354761a7b 100644 (file)
--- a/src/asn1/oid.c
+++ b/src/asn1/oid.c
@@ -16,7 +16,7 @@ free_arcs(struct oid_arcs *arcs)
  *
  * Callers must free @result.
  *
- * TODO (whatever) Most of the time, this function is called to compare @result
+ * TODO (fine) Most of the time, this function is called to compare @result
  * to some oid. Maybe create a wrapper that takes care of all the boilerplate.
  */
 int

diff --git a/src/config.c b/src/config.c
index fe0e4b78c7ce892c6fcc67988e50379c2a7b3d6e..5f2ff73e91661b068ae56106afe9d435910857b9 100644 (file)
--- a/src/config.c
+++ b/src/config.c
@@ -40,7 +40,7 @@ struct rpki_config {
        char *tal;
        /** Path of our local clone of the repository */
        char *local_repository;
-       /** FIXME (later) Deprecated, remove it. RSYNC download strategy. */
+       /** TODO (later) Deprecated, remove it. RSYNC download strategy. */
        enum rsync_strategy sync_strategy;
        /**
         * Handle TAL URIs in random order?
@@ -1042,7 +1042,7 @@ set_default_values(void)
        rpki_config.http.ca_path = NULL; /* Use system default */
 
        /*
-        * FIXME (later) Same values as http.*, delete when rrdp.* is fully
+        * TODO (later) Same values as http.*, delete when rrdp.* is fully
         * deprecated
         */
        rpki_config.rrdp.enabled = rpki_config.http.enabled;
@@ -1153,7 +1153,7 @@ validate_config(void)
            !valid_file_or_dir(rpki_config.slurm, true, true, __pr_op_err))
                return pr_op_err("Invalid slurm location.");
 
-       /* FIXME (later) Remove when sync-strategy is fully deprecated */
+       /* TODO (later) Remove when sync-strategy is fully deprecated */
        if (!rpki_config.rsync.enabled)
                config_set_sync_strategy(RSYNC_OFF);
 

diff --git a/src/config.h b/src/config.h
index d072db2bf085211eedceed1f7ea9505658d5cea7..3a7deca4314f2fda228abdddadf7ae20cb937c9c 100644 (file)
--- a/src/config.h
+++ b/src/config.h
@@ -79,14 +79,14 @@ uint32_t config_get_val_log_facility(void);
  */
 void config_set_rsync_enabled(bool);
 void config_set_http_enabled(bool);
-/* FIXME (later) This will be deprecated */
+/* TODO (later) This will be deprecated */
 void config_set_rrdp_enabled(bool);
 
-/* FIXME (later) Remove when sync-strategy is fully deprecated */
+/* TODO (later) Remove when sync-strategy is fully deprecated */
 void config_set_sync_strategy(enum rsync_strategy);
 void config_set_rsync_strategy(enum rsync_strategy);
 
-/* FIXME (later) Remove once rrdp.* is fully deprecated */
+/* TODO (later) Remove once rrdp.* is fully deprecated */
 void config_set_rrdp_priority(unsigned int);
 void config_set_http_priority(unsigned int);
 void config_set_rrdp_retry_count(unsigned int);

diff --git a/src/config/rrdp_conf.c b/src/config/rrdp_conf.c
index 4ec952f2471619ed3b6cfb36051c3e9c52a018b4..ee533196ae3695efc243e963c99f61c210d03e61 100644 (file)
--- a/src/config/rrdp_conf.c
+++ b/src/config/rrdp_conf.c
@@ -13,7 +13,7 @@
  * Note that this is just a wrapper to set rrdp.* arguments and its equivalent
  * http.* args.
  *
- * FIXME (later) This wrapper will live until all rrdp.* args are fully
+ * TODO (later) This wrapper will live until all rrdp.* args are fully
  * deprecated.
  */
 

diff --git a/src/config/rsync_strategy.c b/src/config/rsync_strategy.c
index b9b3a1dd2cb891b1b0f6fdd93581e991ea3121bf..0131ec8316dc292c9d92fe71795abca258dc1c39 100644 (file)
--- a/src/config/rsync_strategy.c
+++ b/src/config/rsync_strategy.c
@@ -60,7 +60,7 @@ parse_argv_rsync_strategy(struct option_field const *field, char const *str,
                return pr_op_err("Unknown rsync synchronization strategy: '%s'",
                    str);
 
-       /* FIXME (later) Remove when sync-strategy is fully deprecated */
+       /* TODO (later) Remove when sync-strategy is fully deprecated */
        config_set_sync_strategy(DEREFERENCE(result));
 
        return 0;

diff --git a/src/config/rsync_strategy.h b/src/config/rsync_strategy.h
index 11683bdda212f715fd024533645b587fabae7de3..620cff60f3f75f4d399bbe2567f86fd487249bde 100644 (file)
--- a/src/config/rsync_strategy.h
+++ b/src/config/rsync_strategy.h
@@ -5,7 +5,7 @@
 
 enum rsync_strategy {
        /*
-        * FIXME (later) Deprecated. Still alive so that 'sync-strategy' and
+        * TODO (later) Deprecated. Still alive so that 'sync-strategy' and
         * 'rsync.strategy' can live together.
         *
         * 'sync-strategy' type must handle this value to set 'rsync.enabled'
@@ -63,7 +63,7 @@ enum rsync_strategy {
 extern const struct global_type gt_rsync_strategy;
 
 /*
- * FIXME (later) Public to live along with 'sync-strategy', return them to
+ * TODO (later) Public to live along with 'sync-strategy', return them to
  * private whenever 'sync-strategy' is deleted.
  */
 void print_rsync_strategy(struct option_field const *, void *);