]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: change virDomainDefMaybeAddSmartcardController() to return void
authorLaine Stump <laine@redhat.com>
Wed, 12 Feb 2025 03:55:28 +0000 (22:55 -0500)
committerLaine Stump <laine@redhat.com>
Wed, 5 Mar 2025 21:56:45 +0000 (16:56 -0500)
It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/domain_conf.c

index 64ec5205894ec196fa92cb2f26049f1c80ce13e9..e945a0740cff494d81e3d21b67532da856088317 100644 (file)
@@ -22307,7 +22307,7 @@ virDomainDefMaybeAddVirtioSerialController(virDomainDef *def)
 }
 
 
-static int
+static void
 virDomainDefMaybeAddSmartcardController(virDomainDef *def)
 {
     /* Look for any smartcard devs */
@@ -22338,8 +22338,6 @@ virDomainDefMaybeAddSmartcardController(virDomainDef *def)
 
         virDomainDefMaybeAddController(def, VIR_DOMAIN_CONTROLLER_TYPE_CCID, idx, -1);
     }
-
-    return 0;
 }
 
 /*
@@ -22361,10 +22359,7 @@ virDomainDefAddImplicitControllers(virDomainDef *def)
                                           VIR_DOMAIN_DISK_BUS_SATA);
 
     virDomainDefMaybeAddVirtioSerialController(def);
-
-    if (virDomainDefMaybeAddSmartcardController(def) < 0)
-        return -1;
-
+    virDomainDefMaybeAddSmartcardController(def);
     virDomainDefMaybeAddHostdevSCSIcontroller(def);
 
     return 0;