]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clocksource/drivers/sun5i: Remove surplus dev_err() when using platform_get_irq()
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 31 Aug 2023 04:14:14 +0000 (12:14 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 11 Oct 2023 10:06:41 +0000 (12:06 +0200)
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

./drivers/clocksource/timer-sun5i.c:260:2-9: line 260 is redundant because platform_get_irq() already prints an error

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230831041414.66434-1-yang.lee@linux.alibaba.com
drivers/clocksource/timer-sun5i.c

index 69fee3540d375fe730f356e2ec5ae0c137d0d7e4..0d229a9058dad856a897ddbfab6612d549573d25 100644 (file)
@@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "Can't get IRQ\n");
+       if (irq < 0)
                return irq;
-       }
 
        clk = devm_clk_get_enabled(dev, NULL);
        if (IS_ERR(clk)) {