]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
perf: net_dropmonitor: Fix symbol-relative addresses
authorBen Hutchings <ben@decadent.org.uk>
Mon, 20 May 2013 14:45:26 +0000 (14:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Jun 2013 19:49:12 +0000 (12:49 -0700)
commit 5a1e99dd2028e00998d42029be86835d8ef4a46e upstream.

The comparison between traced and symbol addresses is backwards: if
the traced address doesn't exactly match a symbol (which we don't
expect it to), we'll show the next symbol and the offset to it,
whereas we should show the previous symbol and the offset from it.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/perf/scripts/python/net_dropmonitor.py

index adbfbf030576038d1a90d194ee22ebeaa6c8afcb..4c1160560917b1d2ddf36c2ca614f0c011519d36 100755 (executable)
@@ -40,9 +40,9 @@ def get_kallsyms_table():
 
 def get_sym(sloc):
        loc = int(sloc)
-       for i in kallsyms:
-               if (i['loc'] >= loc):
-                       return (i['name'], i['loc']-loc)
+       for i in kallsyms[::-1]:
+               if loc >= i['loc']:
+                       return (i['name'], loc - i['loc'])
        return (None, 0)
 
 def print_drop_table():