]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
usb: renesas_usbhs: Clear pipe running flag in usbhs_pkt_pop()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 1 Feb 2021 12:47:20 +0000 (21:47 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 17:22:54 +0000 (18:22 +0100)
commit 9917f0e3cdba7b9f1a23f70e3f70b1a106be54a8 upstream

Should clear the pipe running flag in usbhs_pkt_pop(). Otherwise,
we cannot use this pipe after dequeue was called while the pipe was
running.

Fixes: 8355b2b3082d ("usb: renesas_usbhs: fix the behavior of some usbhs_pkt_handle")
Reported-by: Tho Vu <tho.vu.wh@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/1612183640-8898-1-git-send-email-yoshihiro.shimoda.uh@renesas.com
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[sudip: adjust context]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/renesas_usbhs/fifo.c

index 4a486fa5473e80c5edfece2e575c9fd042ecc876..3637d5edab741721bd468fac1eb38900621f4f8f 100644 (file)
@@ -137,6 +137,8 @@ struct usbhs_pkt *usbhs_pkt_pop(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt)
                        usbhsf_dma_unmap(pkt);
                }
 
+               usbhs_pipe_running(pipe, 0);
+
                __usbhsf_pkt_del(pkt);
        }