]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftest: af_unix: Silence -Wall warning for scm_pid.c.
authorKuniyuki Iwashima <kuniyu@google.com>
Mon, 11 Aug 2025 21:53:07 +0000 (21:53 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Aug 2025 01:01:53 +0000 (18:01 -0700)
-Wall found 2 unused variables in scm_pid.c:

scm_pidfd.c: In function ‘parse_cmsg’:
scm_pidfd.c:140:13: warning: unused variable ‘data’ [-Wunused-variable]
  140 |         int data = 0;
      |             ^~~~
scm_pidfd.c: In function ‘cmsg_check_dead’:
scm_pidfd.c:246:15: warning: unused variable ‘client_pid’ [-Wunused-variable]
  246 |         pid_t client_pid;
      |               ^~~~~~~~~~

Let's remove these variables.

Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250811215432.3379570-5-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/af_unix/scm_pidfd.c

index 37e034874034885371775c666a513f21f74cfd73..ef2921988e5fd035bbb82b2338dfab29bf841a56 100644 (file)
@@ -137,7 +137,6 @@ struct cmsg_data {
 static int parse_cmsg(struct msghdr *msg, struct cmsg_data *res)
 {
        struct cmsghdr *cmsg;
-       int data = 0;
 
        if (msg->msg_flags & (MSG_TRUNC | MSG_CTRUNC)) {
                log_err("recvmsg: truncated");
@@ -243,7 +242,6 @@ static int cmsg_check_dead(int fd, int expected_pid)
        int data = 0;
        char control[CMSG_SPACE(sizeof(struct ucred)) +
                     CMSG_SPACE(sizeof(int))] = { 0 };
-       pid_t client_pid;
        struct pidfd_info info = {
                .mask = PIDFD_INFO_EXIT,
        };