phy: qcom: Fix ret is uninitialised

In qcom_snps_eusb2_phy_probe after the call to devm_clk_get if an error
is found then ret is printed but has not been assigned to by the code.
Decode the error from the pointer and assign it to ret.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250806-phy_qcom_snps-v1-1-5cda830026c7@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>

diff --git a/drivers/phy/qcom/phy-qcom-snps-eusb2.c b/drivers/phy/qcom/phy-qcom-snps-eusb2.c
index b2655ac007c11df0736313c294ed3f7a66fdef06..28502c46f6794fc950d108e1a98f0b6f82d7e1cf 100644 (file)
--- a/drivers/phy/qcom/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qcom/phy-qcom-snps-eusb2.c
@@ -331,8 +331,9 @@ static int qcom_snps_eusb2_phy_probe(struct udevice *dev)
 
        qcom_snps_eusb2->ref_clk = devm_clk_get(dev, "ref");
        if (IS_ERR(qcom_snps_eusb2->ref_clk)) {
+               ret = PTR_ERR(qcom_snps_eusb2->ref_clk);
                printf("%s: failed to get ref clk %d\n", __func__, ret);
-               return PTR_ERR(qcom_snps_eusb2->ref_clk);
+               return ret;
        }
 
        ret = reset_get_bulk(dev, &qcom_snps_eusb2->resets);