]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
exfat: short-circuit zero-byte writes in exfat_file_write_iter
authorEric Sandeen <sandeen@redhat.com>
Tue, 11 Feb 2025 20:14:21 +0000 (14:14 -0600)
committerNamjae Jeon <linkinjeon@kernel.org>
Wed, 5 Mar 2025 12:53:20 +0000 (21:53 +0900)
When generic_write_checks() returns zero, it means that
iov_iter_count() is zero, and there is no work to do.

Simply return success like all other filesystems do, rather than
proceeding down the write path, which today yields an -EFAULT in
generic_perform_write() via the
(fault_in_iov_iter_readable(i, bytes) == bytes) check when bytes
== 0.

Fixes: 11a347fb6cef ("exfat: change to get file size from DataLength")
Reported-by: Noah <kernel-org-10@maxgrass.eu>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
fs/exfat/file.c

index 05b51e7217838f04fc4836a170b2b9743ecbf16c..807349d8ea05016cdf2a773e054d93d55466356b 100644 (file)
@@ -587,7 +587,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)
        valid_size = ei->valid_size;
 
        ret = generic_write_checks(iocb, iter);
-       if (ret < 0)
+       if (ret <= 0)
                goto unlock;
 
        if (iocb->ki_flags & IOCB_DIRECT) {