]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pwm: core: use device_match_name() instead of strcmp(dev_name(...
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 25 Oct 2024 14:26:34 +0000 (17:26 +0300)
committerUwe Kleine-König <ukleinek@kernel.org>
Fri, 25 Oct 2024 20:52:45 +0000 (22:52 +0200)
Use the dedicated helper for comparing device names against strings.

Note, the current code has a check for the dev_name() against NULL.
With the current implementations of the device_add() and dev_set_name()
it most likely a theoretical assumption that that might happen, while
I don't see how. Hence, that check has simply been removed.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20241025142704.405340-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/core.c

index 634be56e204b2dab7242f18dbbaeead0a5bed1d2..4399e793efaf4680e01856f39206828974ef61af 100644 (file)
@@ -852,9 +852,7 @@ static struct pwm_chip *pwmchip_find_by_name(const char *name)
        guard(mutex)(&pwm_lock);
 
        idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) {
-               const char *chip_name = dev_name(pwmchip_parent(chip));
-
-               if (chip_name && strcmp(chip_name, name) == 0)
+               if (device_match_name(pwmchip_parent(chip), name))
                        return chip;
        }