]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
md: remove legacy 1s delay in md_notify_reboot
authorTarun Sahu <tarunsahu@google.com>
Fri, 21 Nov 2025 19:14:22 +0000 (19:14 +0000)
committerYu Kuai <yukuai@fnnas.com>
Sun, 30 Nov 2025 01:42:28 +0000 (09:42 +0800)
During system shutdown, the md driver registered notifier function
(md_notify_reboot) currently imposes a hardcoded one-second delay.

This delay was introduced approximately 23 years ago and was likely
necessary for the hardware generation of that time. Proposing this
patch to make sure there are no known devices that need this delay.

Link: https://lore.kernel.org/linux-raid/20251121191422.2758555-1-tarunsahu@google.com
Signed-off-by: Tarun Sahu <tarunsahu@google.com>
Reviewed-by: Yu Kuai<yukuai@fnnas.com>
Signed-off-by: Yu Kuai <yukuai@fnnas.com>
drivers/md/md.c

index 345b1e623abaf44f02d39c29535a3f2c58e7838f..e5922a6829532fb876eed524bc9aef28f36f8d13 100644 (file)
@@ -10408,7 +10408,6 @@ static int md_notify_reboot(struct notifier_block *this,
                            unsigned long code, void *x)
 {
        struct mddev *mddev;
-       int need_delay = 0;
 
        spin_lock(&all_mddevs_lock);
        list_for_each_entry(mddev, &all_mddevs, all_mddevs) {
@@ -10422,21 +10421,11 @@ static int md_notify_reboot(struct notifier_block *this,
                                mddev->safemode = 2;
                        mddev_unlock(mddev);
                }
-               need_delay = 1;
                spin_lock(&all_mddevs_lock);
                mddev_put_locked(mddev);
        }
        spin_unlock(&all_mddevs_lock);
 
-       /*
-        * certain more exotic SCSI devices are known to be
-        * volatile wrt too early system reboots. While the
-        * right place to handle this issue is the given
-        * driver, we do want to have a safe RAID driver ...
-        */
-       if (need_delay)
-               msleep(1000);
-
        return NOTIFY_DONE;
 }