]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
soundwire: generic_bandwidth_allocation: skip DEPREPARED streams
authorPierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Wed, 18 Dec 2024 08:01:46 +0000 (16:01 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 23 Dec 2024 06:30:33 +0000 (12:00 +0530)
We should not blindly walk through all the m_rt list, since it will
have the side effect of accounting for deprepared streams.

This behavior is the result of the split implementation where the
dailink hw_free() handles the stream state change and the bit
allocation, and the dai hw_free() modifies the m_rt list. The bit
allocation ends-up using m_rt entries in zombie state, no longer
relevant but still used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20241218080155.102405-6-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/generic_bandwidth_allocation.c

index abf9b85daa52dd47bdc1689c55626038f8ba013b..2950a3d002ce2d651e392305c00e77428a8481ea 100644 (file)
@@ -238,6 +238,9 @@ static int sdw_get_group_count(struct sdw_bus *bus,
                return -ENOMEM;
 
        list_for_each_entry(m_rt, &bus->m_rt_list, bus_node) {
+               if (m_rt->stream->state == SDW_STREAM_DEPREPARED)
+                       continue;
+
                rate = m_rt->stream->params.rate;
                if (m_rt == list_first_entry(&bus->m_rt_list,
                                             struct sdw_master_runtime,