]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/edid: reduce DisplayID log spamming
authorJani Nikula <jani.nikula@intel.com>
Thu, 6 Jun 2024 12:35:03 +0000 (15:35 +0300)
committerJani Nikula <jani.nikula@intel.com>
Wed, 14 Aug 2024 07:19:09 +0000 (10:19 +0300)
Debug printing at DisplayID validation leads to lots of log spamming as
it's called at DisplayID iterators during EDID parsing. Remove it, and
replace with a less noisy message at connector EDID update.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240606123503.2825088-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/drm_displayid.c
drivers/gpu/drm/drm_edid.c

index 9d01d762801ff2429a0ef49e7245bbd34cf0f373..b4fd43783c5096df92d90402f2acd93dd26f2f64 100644 (file)
@@ -33,9 +33,6 @@ validate_displayid(const u8 *displayid, int length, int idx)
        if (IS_ERR(base))
                return base;
 
-       DRM_DEBUG_KMS("base revision 0x%x, length %d, %d %d\n",
-                     base->rev, base->bytes, base->prod_id, base->ext_count);
-
        /* +1 for DispID checksum */
        dispid_length = sizeof(*base) + base->bytes + 1;
        if (dispid_length > length - idx)
index f68a41eeb1fa80e4e6544eb8b484cd9bff268f3d..9fc7292f5382e1c44f9f4cd02845f856788f88ed 100644 (file)
@@ -6629,6 +6629,11 @@ static void update_displayid_info(struct drm_connector *connector,
 
        displayid_iter_edid_begin(drm_edid, &iter);
        displayid_iter_for_each(block, &iter) {
+               drm_dbg_kms(connector->dev,
+                           "[CONNECTOR:%d:%s] DisplayID extension version 0x%02x, primary use 0x%02x\n",
+                           connector->base.id, connector->name,
+                           displayid_version(&iter),
+                           displayid_primary_use(&iter));
                if (displayid_version(&iter) == DISPLAY_ID_STRUCTURE_VER_20 &&
                    (displayid_primary_use(&iter) == PRIMARY_USE_HEAD_MOUNTED_VR ||
                     displayid_primary_use(&iter) == PRIMARY_USE_HEAD_MOUNTED_AR))