]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE_DOWN...
authorJiri Kosina <jkosina@suse.com>
Wed, 12 Mar 2025 08:08:22 +0000 (09:08 +0100)
committerJiri Kosina <jkosina@suse.com>
Wed, 12 Mar 2025 17:56:35 +0000 (18:56 +0100)
The line

obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)   += intel-ish-hid/

in top-level HID Makefile is both superfluous (as CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/ already) and wrong (as it's
missing the CONFIG_ prefix).

Just remove it.

Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client driver")
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/Makefile

index 482b096eea28087b01d667c0e2c83382c132f017..0abfe51704a0b4678c93b921850f71815244c16d 100644 (file)
@@ -166,7 +166,6 @@ obj-$(CONFIG_USB_KBD)               += usbhid/
 obj-$(CONFIG_I2C_HID_CORE)     += i2c-hid/
 
 obj-$(CONFIG_INTEL_ISH_HID)    += intel-ish-hid/
-obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)   += intel-ish-hid/
 
 obj-$(CONFIG_AMD_SFH_HID)       += amd-sfh-hid/