]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
test: fix coverity 1371689 & 1371690: improper use of negative values
authorPauli <ppzgs1@gmail.com>
Mon, 22 Mar 2021 01:49:56 +0000 (11:49 +1000)
committerPauli <ppzgs1@gmail.com>
Tue, 23 Mar 2021 23:12:43 +0000 (09:12 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14638)

test/bad_dtls_test.c

index 524ec52cf01ac93991fc9075ef8dd0f1387b80cb..52333e860c5aa7532c14af4358e506d357e514b3 100644 (file)
@@ -122,7 +122,8 @@ static int validate_client_hello(BIO *wbio)
     int cookie_found = 0;
     unsigned int u = 0;
 
-    len = BIO_get_mem_data(wbio, (char **)&data);
+    if ((len = BIO_get_mem_data(wbio, (char **)&data)) < 0)
+        return 0;
     if (!PACKET_buf_init(&pkt, data, len))
         return 0;
 
@@ -391,6 +392,9 @@ static int validate_ccs(BIO *wbio)
     unsigned int u;
 
     len = BIO_get_mem_data(wbio, (char **)&data);
+    if (len < 0)
+        return 0;
+
     if (!PACKET_buf_init(&pkt, data, len))
         return 0;