]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
serial: 8250_of: Remove unneeded ->iotype assignment
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 24 Jan 2025 16:10:49 +0000 (18:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Feb 2025 13:44:50 +0000 (14:44 +0100)
If ->iobase is set the default will be UPIO_PORT for ->iotype after
the uart_read_and_validate_port_properties() call. Hence no need
to assign that explicitly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250124161530.398361-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_of.c

index 64aed7efc569703711131e2f5127f36a634718bc..11c860ea80f60f3d24c368b4efcad35a5fcc3c67 100644 (file)
@@ -110,7 +110,6 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
        spin_lock_init(&port->lock);
 
        if (resource_type(&resource) == IORESOURCE_IO) {
-               port->iotype = UPIO_PORT;
                port->iobase = resource.start;
        } else {
                port->mapbase = resource.start;