lldpcli: add a test for return code

diff --git a/NEWS b/NEWS
index d8ffdf1b5e247a8accefac9668e828f9dafb340e..12b430f413d9aa8eed9e485a21c3fc23051301c7 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ lldpd (0.9.4)
   * Fix:
     + Fix setting of local value for port ID.
     + Fix compilation with BSD make.
+    + Ensure lldpcli returns an error code on invalid commands.
 
 lldpd (0.9.3)
   * Change:

diff --git a/tests/integration/test_lldpcli.py b/tests/integration/test_lldpcli.py
index 40a5e2c3513055a9b448bc02be99d71dacb0592d..e224e448b10f5b9dd35725669cd8945c9fad7806 100644 (file)
--- a/tests/integration/test_lldpcli.py
+++ b/tests/integration/test_lldpcli.py
@@ -283,3 +283,11 @@ def test_watch_json(lldpd1, lldpd, lldpcli, namespaces, links):
         del expected['lldp-deleted']['interface']['eth0']['age']
         del got['lldp-deleted']['interface']['eth0']['age']
         assert got == expected
+
+
+def test_return_code(lldpd1, lldpcli, namespaces):
+    with namespaces(1):
+        result = lldpcli("show", "neighbors")
+        assert result.returncode == 0
+        result = lldpcli("unknown", "command")
+        assert result.returncode == 1