]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
proc: consoles: Add notation to c_start/c_stop
authorJohn Ogness <john.ogness@linutronix.de>
Wed, 4 Sep 2024 12:05:31 +0000 (14:11 +0206)
committerPetr Mladek <pmladek@suse.com>
Wed, 4 Sep 2024 13:56:32 +0000 (15:56 +0200)
fs/proc/consoles.c:78:13: warning: context imbalance in 'c_start'
- wrong count at exit
fs/proc/consoles.c:104:13: warning: context imbalance in 'c_stop'
- unexpected unlock

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20240904120536.115780-13-john.ogness@linutronix.de
Signed-off-by: Petr Mladek <pmladek@suse.com>
fs/proc/consoles.c

index e0758fe7936dce4498cd75e2212a2ce35f3d47b0..7036fdfa0becb745055a9dd43eb973f7eb1aa156 100644 (file)
@@ -68,6 +68,7 @@ static int show_console_dev(struct seq_file *m, void *v)
 }
 
 static void *c_start(struct seq_file *m, loff_t *pos)
+       __acquires(&console_mutex)
 {
        struct console *con;
        loff_t off = 0;
@@ -94,6 +95,7 @@ static void *c_next(struct seq_file *m, void *v, loff_t *pos)
 }
 
 static void c_stop(struct seq_file *m, void *v)
+       __releases(&console_mutex)
 {
        console_list_unlock();
 }