decl.c (duplicate_decls): Preserve linkage flags for mere redeclarations of gnu_inlin...

2007-10-01  Alexandre Oliva  <aoliva@redhat.com>

	* decl.c (duplicate_decls): Preserve linkage flags for mere
	redeclarations of gnu_inline definitions.

	* g++.dg/ext/gnu-inline-global-redecl.C: New.

From-SVN: r128992

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 02d549f87e9a9ddb5b10048b4d588b18f12dd23b..2efe051eb8ff42950cb222e6b99878fac55dbac3 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2007-10-03  Alexandre Oliva  <aoliva@redhat.com>
+
+       * decl.c (duplicate_decls): Preserve linkage flags for mere
+       redeclarations of gnu_inline definitions.
+
 2007-10-03  Jason Merrill  <jason@redhat.com>
 
        PR c++/15764

diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index d653fc490d10068aa627dc4ecec41f9579c6d0d3..83195af1b49dec3a543df7f9a778befa02c6a421 100644 (file)
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -1846,24 +1846,24 @@ duplicate_decls (tree newdecl, tree olddecl, bool newdecl_is_friend)
   new_template = NULL_TREE;
   if (DECL_LANG_SPECIFIC (newdecl) && DECL_LANG_SPECIFIC (olddecl))
     {
-      bool old_decl_gnu_inline;
+      bool new_redefines_gnu_inline = false;
 
-      if ((DECL_INTERFACE_KNOWN (olddecl)
-          && TREE_CODE (olddecl) == FUNCTION_DECL)
-         || (TREE_CODE (olddecl) == TEMPLATE_DECL
-             && TREE_CODE (DECL_TEMPLATE_RESULT (olddecl)) == FUNCTION_DECL))
+      if (new_defines_function
+         && ((DECL_INTERFACE_KNOWN (olddecl)
+              && TREE_CODE (olddecl) == FUNCTION_DECL)
+             || (TREE_CODE (olddecl) == TEMPLATE_DECL
+                 && (TREE_CODE (DECL_TEMPLATE_RESULT (olddecl))
+                     == FUNCTION_DECL))))
        {
          tree fn = olddecl;
 
          if (TREE_CODE (fn) == TEMPLATE_DECL)
            fn = DECL_TEMPLATE_RESULT (olddecl);
 
-         old_decl_gnu_inline = GNU_INLINE_P (fn) && DECL_INITIAL (fn);
+         new_redefines_gnu_inline = GNU_INLINE_P (fn) && DECL_INITIAL (fn);
        }
-      else
-       old_decl_gnu_inline = false;
 
-      if (!old_decl_gnu_inline)
+      if (!new_redefines_gnu_inline)
        {
          DECL_INTERFACE_KNOWN (newdecl) |= DECL_INTERFACE_KNOWN (olddecl);
          DECL_NOT_REALLY_EXTERN (newdecl) |= DECL_NOT_REALLY_EXTERN (olddecl);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 277c25d5e311992f0578a8d0bc5de5f8be4276e0..017341160a91cbd2fc4c0796effcedd9eb4377f0 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2007-10-03  Alexandre Oliva  <aoliva@redhat.com>
+
+       * g++.dg/ext/gnu-inline-global-redecl.C: New.
+
 2007-10-03  Richard Sandiford  <rsandifo@nildram.co.uk>
 
        PR target/33635

diff --git a/gcc/testsuite/g++.dg/ext/gnu-inline-global-redecl.C b/gcc/testsuite/g++.dg/ext/gnu-inline-global-redecl.C
new file mode 100644 (file)
index 0000000..fc72d26
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/gnu-inline-global-redecl.C
@@ -0,0 +1,19 @@
+/* Test __attribute__((gnu_inline)).
+
+   Check that we don't get out-of-line definitions for extern inline
+   gnu_inline functions, regardless of redeclaration.
+
+ */
+
+/* { dg-do link } */
+/* { dg-options "-O" } */ // such that static functions are optimized out
+
+#include "gnu-inline-common.h"
+
+decl(extern, fn)
+gnuindef(fn, 0)
+decl(extern, fn)
+
+int main () {
+  fn ();
+}

diff --git a/gcc/tree-ssa-ter.c b/gcc/tree-ssa-ter.c
index f0fef24aa4a574f2bdae0cae2bea649d93cd3137..424ccbe6fcb12de1200f06d171c55194fff2aac7 100644 (file)
--- a/gcc/tree-ssa-ter.c
+++ b/gcc/tree-ssa-ter.c
@@ -443,7 +443,7 @@ finished_with_expr (temp_expr_table_p tab, int version, bool free_expr)
 }
 
 
-/* Create an expression entry fora replaceable expression.  */
+/* Create an expression entry for a replaceable expression.  */
 
 static void 
 process_replaceable (temp_expr_table_p tab, tree stmt)