]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
RISC-V: Bugfix PR111362 for incorrect frm emit
authorPan Li <pan2.li@intel.com>
Wed, 13 Sep 2023 03:34:42 +0000 (11:34 +0800)
committerPan Li <pan2.li@intel.com>
Wed, 13 Sep 2023 06:19:14 +0000 (14:19 +0800)
When the mode switching from NONE to CALL, we will restore the
frm but lack some check if we have static frm insn in cfun.

This patch would like to fix this by adding static frm insn check.

PR target/111362

gcc/ChangeLog:

* config/riscv/riscv.cc (riscv_emit_frm_mode_set): Bugfix.

gcc/testsuite/ChangeLog:

* gcc.target/riscv/rvv/base/no-honor-frm-1.c: New test.

Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/config/riscv/riscv.cc
gcc/testsuite/gcc.target/riscv/rvv/base/no-honor-frm-1.c [new file with mode: 0644]

index 9d04ddd69e07e14bed4a6b128fb10a81b2e75429..762937b0e373796d30cdeb0831606a8b3f657fea 100644 (file)
@@ -9173,7 +9173,7 @@ riscv_emit_frm_mode_set (int mode, int prev_mode)
       rtx frm = gen_int_mode (mode, SImode);
 
       if (mode == riscv_vector::FRM_DYN_CALL
-       && prev_mode != riscv_vector::FRM_DYN)
+       && prev_mode != riscv_vector::FRM_DYN && STATIC_FRM_P (cfun))
        /* No need to emit when prev mode is DYN already.  */
        emit_insn (gen_fsrmsi_restore_volatile (backup_reg));
       else if (mode == riscv_vector::FRM_DYN_EXIT && STATIC_FRM_P (cfun)
diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/no-honor-frm-1.c b/gcc/testsuite/gcc.target/riscv/rvv/base/no-honor-frm-1.c
new file mode 100644 (file)
index 0000000..b2e0f21
--- /dev/null
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gcv -mabi=lp64 -O3 -Wno-psabi" } */
+
+void foo (void) {
+  for (unsigned i = 0; i < sizeof(foo); i++)
+    __builtin_printf("%d", i);
+}
+
+/* { dg-final { scan-assembler-not {fsrmi\s+[axs][0-9]+,\s*[01234]} } } */
+/* { dg-final { scan-assembler-not {fsrmi\s+[01234]} } } */
+/* { dg-final { scan-assembler-not {fsrm\s+[axs][0-9]+} } } */
+/* { dg-final { scan-assembler-not {frrm\s+[axs][0-9]+} } } */