]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: gpib: Remove unused value
authorEverest K.C. <everestkc@everestkc.com.np>
Wed, 16 Oct 2024 07:55:43 +0000 (01:55 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Oct 2024 08:04:49 +0000 (10:04 +0200)
The variable `complement_count` is assigned a value which is again
overwritten in the next statement.
Fix this by removing the first value assigning statement

This issue was reported by Coverity Scan.
Report:
CID 1600790: (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value from length to complement_count here,
but that stored value is overwritten before it can be used.

Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20241016075544.4125-1-everestkc@everestkc.com.np
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/ni_usb/ni_usb_gpib.c

index 75f39e1f3ed1f7d47593f485102b44c5b4027719..28b17575a46377e3267b76cf45140149d7d260d5 100644 (file)
@@ -759,7 +759,6 @@ static int ni_usb_write(gpib_board_t *board, uint8_t *buffer, size_t length,
        if (!out_data)
                return -ENOMEM;
        out_data[i++] = 0x0d;
-       complement_count = length;
        complement_count = length - 1;
        complement_count = ~complement_count;
        out_data[i++] = complement_count & 0xff;