s3:smb2: debug mentions function name fewer times

There was a complaint about messages like this

../../source3/smbd/smb2_server.c:4058(smbd_smb2_request_error_ex)
smbd_smb2_request_error_ex: smbd_smb2_request_error_ex: idx[1]
status[NT_STATUS_OBJECT_NAME_NOT_FOUND] || at
../../source3/smbd/smb2_create.c:360

which weren't informing the admin know what was really
wrong. This patch doesn't help, but it does avoid
saying "smbd_smb2_request_error_ex" three times.

REF: https://lists.samba.org/archive/samba/2025-February/250967.html

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Rowland Penny <rpenny@samba.org>

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 5c3b7b90dc91aa1dc7f9bcca0f521be01fd9f5c2..3b692fdca87487d5192466f30865c7e52ab46d10 100644 (file)
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -4077,7 +4077,7 @@ NTSTATUS smbd_smb2_request_error_ex(struct smbd_smb2_request *req,
        uint8_t *outhdr = SMBD_SMB2_OUT_HDR_PTR(req);
        size_t unread_bytes = smbd_smb2_unread_bytes(req);
 
-       DBG_NOTICE("smbd_smb2_request_error_ex: idx[%d] status[%s] |%s| "
+       DBG_NOTICE("idx[%d] status[%s] |%s| "
                   "at %s\n", req->current_idx, nt_errstr(status),
                   info ? " +info" : "", location);