]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: mediatek: mt8188: Mark AFE_DAC_CON0 register as volatile
authorYR Yang <yr.yang@mediatek.com>
Thu, 1 Aug 2024 08:43:26 +0000 (16:43 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 14 Aug 2024 20:56:34 +0000 (21:56 +0100)
Add AFE Control Register 0 to the volatile_register.
AFE_DAC_CON0 can be modified by both the SOF and ALSA drivers.
If this register is read and written in cache mode, the cached value
might not reflect the actual value when the register is modified by
another driver. It can cause playback or capture failures. Therefore,
it is necessary to add AFE_DAC_CON0 to the list of volatile registers.

Signed-off-by: YR Yang <yr.yang@mediatek.com>
Reviewed-by: Fei Shao <fshao@chromium.org>
Reviewed-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://patch.msgid.link/20240801084326.1472-1-yr.yang@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8188/mt8188-afe-pcm.c

index ccb6c1f3adc7d998852a4439b6981afc6c2e5709..73e5c63aeec8783905d656af225c42cd95069049 100644 (file)
@@ -2748,6 +2748,7 @@ static bool mt8188_is_volatile_reg(struct device *dev, unsigned int reg)
        case AFE_ASRC12_NEW_CON9:
        case AFE_LRCK_CNT:
        case AFE_DAC_MON0:
+       case AFE_DAC_CON0:
        case AFE_DL2_CUR:
        case AFE_DL3_CUR:
        case AFE_DL6_CUR: