powerpc64-ld infinite loop

If this code dealing with possible conversion of inline plt sequences
is ever executed, ld will hang.  A binary with such sequences and of
code size larger than approximately 90% the reach of an unconditional
branch is the trigger.  Oops.

	* elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.

(cherry picked from commit 435edf0bf231240ccecb474b74ebb49dc8db2633)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 4af15327dbf3d68a3aa3da894c1a6c36c5d4a3ac..30defb5e224051e42b7579df7a9aa961933e2fcc 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11  Alan Modra  <amodra@gmail.com>
+
+       * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
+
 2019-04-24  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR ld/24458

diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 746506ef09e9f135a4460ea0429011608093efac..657a5595afdc4292bd77223e960538c1cbe77463 100644 (file)
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -8391,7 +8391,7 @@ ppc64_elf_inline_plt (struct bfd_link_info *info)
              return FALSE;
 
            relend = relstart + sec->reloc_count;
-           for (rel = relstart; rel < relend; )
+           for (rel = relstart; rel < relend; rel++)
              {
                enum elf_ppc64_reloc_type r_type;
                unsigned long r_symndx;