Add two comments based on code review

diff --git a/pdns/recursordist/Makefile.am b/pdns/recursordist/Makefile.am
index fe687c6f46fe37c6c73d7ca138dae987120c6665..9c157f43c07e31b9e5f99991576e475f7651a5af 100644 (file)
--- a/pdns/recursordist/Makefile.am
+++ b/pdns/recursordist/Makefile.am
@@ -315,9 +315,9 @@ testrunner_SOURCES = \
        test-negcache_cc.cc \
        test-packetcache_hh.cc \
        test-rcpgenerator_cc.cc \
+       test-rec-zonetocache.cc \
        test-recpacketcache_cc.cc \
        test-recursorcache_cc.cc \
-       test-rec-zonetocache.cc \
        test-rpzloader_cc.cc \
        test-secpoll_cc.cc \
        test-signers.cc \

diff --git a/pdns/recursordist/rec-zonetocache.cc b/pdns/recursordist/rec-zonetocache.cc
index ea614df3558a7af5f74d144a938ab4e2e7785b98..6fdf7568d90de2c51fc827e3b75757c1271e68bb 100644 (file)
--- a/pdns/recursordist/rec-zonetocache.cc
+++ b/pdns/recursordist/rec-zonetocache.cc
@@ -42,9 +42,14 @@ struct ZoneData
   ZoneData(shared_ptr<Logr::Logger>& log) :
     d_log(log) {}
 
+  // Potentially the two fields below could be merged into a single map. ATM it is not clear to me
+  // if that would make the code easier to read.
   std::map<pair<DNSName, QType>, vector<DNSRecord>> d_all;
   std::map<pair<DNSName, QType>, vector<shared_ptr<RRSIGRecordContent>>> d_sigs;
+
+  // Maybe use a SuffixMatchTree?
   std::set<DNSName> d_delegations;
+
   time_t d_now;
   DNSName d_zone;
   shared_ptr<Logr::Logger>& d_log;