udev-test: skip the test only if it can't setup its environment

This is basically a replacement for 0eb3cc88504b5d8f74.

diff --git a/src/test/test-udev.c b/src/test/test-udev.c
index e972b56b2ca1ba9a50d5a4b4febbc0e6daec26ee..9f3aba70ab3acbecfefe399ba8efd2e004a1536d 100644 (file)
--- a/src/test/test-udev.c
+++ b/src/test/test-udev.c
@@ -61,14 +61,17 @@ int main(int argc, char *argv[]) {
 
         test_setup_logging(LOG_INFO);
 
-        if (argc != 3) {
-                log_error("This program needs two arguments, %d given", argc - 1);
+        if (!IN_SET(argc, 2, 3)) {
+                log_error("This program needs one or two arguments, %d given", argc - 1);
                 return EXIT_FAILURE;
         }
 
         if (fake_filesystems() < 0)
                 return EXIT_FAILURE;
 
+        if (argc == 2)
+                return EXIT_SUCCESS;
+
         log_debug("version %s", PACKAGE_VERSION);
         mac_selinux_init();
 

diff --git a/test/udev-test.pl b/test/udev-test.pl
index 05b3e1718819fd29a6400da167baf619ae6b643e..aa38bae0b1cd1fc4346b03140adf01aba31d1608 100755 (executable)
--- a/test/udev-test.pl
+++ b/test/udev-test.pl
@@ -1537,18 +1537,28 @@ sub udev_setup {
         system("umount", $udev_tmpfs);
         rmdir($udev_tmpfs);
         mkdir($udev_tmpfs) || die "unable to create udev_tmpfs: $udev_tmpfs\n";
-        system("mount", "-o", "rw,mode=755,nosuid,noexec", "-t", "tmpfs", "tmpfs", $udev_tmpfs) && die "unable to mount tmpfs";
+
+        if (system("mount", "-o", "rw,mode=755,nosuid,noexec", "-t", "tmpfs", "tmpfs", $udev_tmpfs)) {
+                warn "unable to mount tmpfs";
+                return 0;
+        }
 
         mkdir($udev_dev) || die "unable to create udev_dev: $udev_dev\n";
         # setting group and mode of udev_dev ensures the tests work
         # even if the parent directory has setgid bit enabled.
         chown (0, 0, $udev_dev) || die "unable to chown $udev_dev\n";
         chmod (0755, $udev_dev) || die "unable to chmod $udev_dev\n";
-        system("mknod", $udev_dev . "/null", "c", "1", "3") && die "unable to create $udev_dev/null";
+
+        if (system("mknod", $udev_dev . "/null", "c", "1", "3")) {
+                warn "unable to create $udev_dev/null";
+                return 0;
+        }
 
         system("cp", "-r", "test/sys/", $udev_sys) && die "unable to copy test/sys";
 
         system("rm", "-rf", "$udev_run");
+
+        return 1;
 }
 
 sub run_test {
@@ -1646,7 +1656,15 @@ if ($? >> 8 == 0) {
         exit($EXIT_TEST_SKIP);
 }
 
-udev_setup();
+if (!udev_setup()) {
+        warn "Failed to set up the environment, skipping the test";
+        exit($EXIT_TEST_SKIP);
+}
+
+if (!system($udev_bin, "check")) {
+        warn "$udev_bin failed to set up the environment, skipping the test";
+        exit($EXIT_TEST_SKIP);
+}
 
 my $test_num = 1;
 my @list;