]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Rename the 'queued' metric of the Remote Logger to 'processed' 10821/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 7 Oct 2021 12:34:02 +0000 (14:34 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 7 Oct 2021 12:34:02 +0000 (14:34 +0200)
Since it was not clear at all whether 'queued' meant 'has been put
in the queue at some point, might have been sent or not' or 'actually
still in the queue' (it was the former).

pdns/remote_logger.cc
pdns/remote_logger.hh

index 736091118fcf9ab614a4ab66d2031e80b133e7dc..6e41db647f4e843b44227c84115334295b043031 100644 (file)
@@ -170,7 +170,7 @@ void RemoteLogger::queueData(const std::string& data)
   }
 
   runtime->d_writer.write(data);
-  ++d_queued;
+  ++d_processed;
 }
 
 void RemoteLogger::maintenanceThread() 
index c00e882f228f6a78b8f76bf8a373c83afbe025eb..04db3b53ad865d5e980fa099b514ba62e2e9f764 100644 (file)
@@ -90,7 +90,7 @@ public:
   void queueData(const std::string& data) override;
   std::string toString() const override
   {
-    return d_remote.toStringWithPort() + " (" + std::to_string(d_queued) + " queued, " + std::to_string(d_drops) + " dropped)";
+    return d_remote.toStringWithPort() + " (" + std::to_string(d_processed) + " processed, " + std::to_string(d_drops) + " dropped)";
   }
   void stop()
   {
@@ -109,7 +109,7 @@ private:
 
   ComboAddress d_remote;
   std::atomic<uint64_t> d_drops{0};
-  std::atomic<uint64_t> d_queued{0};
+  std::atomic<uint64_t> d_processed{0};
   uint16_t d_timeout;
   uint8_t d_reconnectWaitTime;
   std::atomic<bool> d_exiting{false};