format-table: never try to reuse cells that have color/url/uppercase set

The table cell reusing code is supposed to be an internal memory
optimization, and not more. This means behaviour should be the same as
if we wouldn't reuse cells.

diff --git a/src/shared/format-table.c b/src/shared/format-table.c
index 6fdb583a72dc21e1bebf6acb92390dbab190ce81..7d529801a1da81d56ea2c9da3dc081fa4c6ec353 100644 (file)
--- a/src/shared/format-table.c
+++ b/src/shared/format-table.c
@@ -270,6 +270,14 @@ static bool table_data_matches(
         if (d->ellipsize_percent != ellipsize_percent)
                 return false;
 
+        /* If a color/url/uppercase flag is set, refuse to merge */
+        if (d->color)
+                return false;
+        if (d->url)
+                return false;
+        if (d->uppercase)
+                return false;
+
         k = table_data_size(type, data);
         l = table_data_size(d->type, d->data);