Tweak for Coverity 1488422.

The spot where the warning happens changed, plus appease clang-tidy.

diff --git a/pdns/signingpipe.cc b/pdns/signingpipe.cc
index 30bd41a81288451336d613a37f96196b3b3acfc6..0198686d5c24651e8e2e6840db54f88172ed9750 100644 (file)
--- a/pdns/signingpipe.cc
+++ b/pdns/signingpipe.cc
@@ -201,13 +201,13 @@ void ChunkedSigningPipe::sendRRSetToWorker() // it sounds so socialist!
     shuffle(rwVect.second.begin(), rwVect.second.end(), pdns::dns_random_engine()); // pick random available worker
     auto ptr = d_rrsetToSign.get();
     writen2(*rwVect.second.begin(), &ptr, sizeof(ptr));
-    d_rrsetToSign.release();
+    // coverity[leaked_storage]
+    static_cast<void>(d_rrsetToSign.release());
     d_rrsetToSign = make_unique<rrset_t>();
     d_outstandings[*rwVect.second.begin()]++;
     d_outstanding++;
     d_queued++;
     wantWrite=false;
-    // coverity[leaked_storage]
   } 
   
   if(wantRead) {
@@ -252,12 +252,12 @@ void ChunkedSigningPipe::sendRRSetToWorker() // it sounds so socialist!
     shuffle(rwVect.second.begin(), rwVect.second.end(), pdns::dns_random_engine()); // pick random available worker
     auto ptr = d_rrsetToSign.get();
     writen2(*rwVect.second.begin(), &ptr, sizeof(ptr));
-    d_rrsetToSign.release();
+    // coverity[leaked_storage]
+    static_cast<void>(d_rrsetToSign.release());
     d_rrsetToSign = make_unique<rrset_t>();
     d_outstandings[*rwVect.second.begin()]++;
     d_outstanding++;
     d_queued++;
-    // coverity[leaked_storage]
   }
   
 }