credentials: Explicitly clear credentials once they have been moved

diff --git a/pdns/credentials.cc b/pdns/credentials.cc
index ef37eaee6cf3585d22a227f5c8a02017456d83a2..b086788a5ff418cba95e1fc47c1ec295392ab294 100644 (file)
--- a/pdns/credentials.cc
+++ b/pdns/credentials.cc
@@ -62,6 +62,7 @@ uint64_t const CredentialsHolder::s_defaultBlockSize{8U}; /* r */
 SensitiveData::SensitiveData(std::string&& data) :
   d_data(std::move(data))
 {
+  data.clear();
 #ifdef HAVE_LIBSODIUM
   sodium_mlock(d_data.data(), d_data.size());
 #endif
@@ -70,6 +71,7 @@ SensitiveData::SensitiveData(std::string&& data) :
 SensitiveData& SensitiveData::operator=(SensitiveData&& rhs)
 {
   d_data = std::move(rhs.d_data);
+  rhs.clear();
   return *this;
 }