c/r: use snprintf to compute device name

This will never actually overflow, because %d is 32 bits and eth is 128
bytes long, but safety first :)

Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>

diff --git a/src/lxc/criu.c b/src/lxc/criu.c
index 16d439a89a3bfee44a88998ac183a4bd9e270ce7..094096777cb63b1cc4942a21882c4870641dd2b9 100644 (file)
--- a/src/lxc/criu.c
+++ b/src/lxc/criu.c
@@ -443,8 +443,11 @@ static void exec_criu(struct criu_opts *opts)
                                if (strlen(n->name) >= sizeof(eth))
                                        goto err;
                                strncpy(eth, n->name, sizeof(eth));
-                       } else
-                               sprintf(eth, "eth%d", netnr);
+                       } else {
+                               ret = snprintf(eth, sizeof(eth), "eth%d", netnr);
+                               if (ret < 0 || ret >= sizeof(eth))
+                                       goto err;
+                       }
 
                        switch (n->type) {
                        case LXC_NET_VETH: