rec: uid_t and gid_t can be unsigned, so doing > on and -1 value is tricky

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 416609fa70a9ea4927d0662be7f8bcf5cef1821a..8c9fefe1c32c72a8637d7e8993beef8ce310a068 100644 (file)
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -682,7 +682,7 @@ static void makeControlChannelSocket(int processNum = -1)
     sockowner = ::arg().asUid("socket-owner");
   }
 
-  if (sockgroup > -1 || sockowner > -1) {
+  if (sockgroup != static_cast<gid_t>(-1) || sockowner != static_cast<uid_t>(-1)) {
     if (chown(sockname.c_str(), sockowner, sockgroup) < 0) {
       unixDie("Failed to chown control socket");
     }