]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
simplify return type usage 13879/head
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Mon, 11 Mar 2024 11:39:36 +0000 (12:39 +0100)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Mon, 11 Mar 2024 12:16:54 +0000 (13:16 +0100)
pdns/lua-record.cc

index ed1839c68dffa5d7425cea80a7e1e1d492f3b383..86c4450bee633e286f9aec294f7424b0b3a9db61 100644 (file)
@@ -1057,24 +1057,24 @@ static void setupLuaRecords(LuaContext& lua) // NOLINT(readability-function-cogn
       return std::string("unknown");
     });
 
-  lua.writeFunction("filterForward", [](string address, NetmaskGroup& nmg, boost::optional<string> fallback) {
+  lua.writeFunction("filterForward", [](const string& address, NetmaskGroup& nmg, boost::optional<string> fallback) -> vector<string> {
       ComboAddress ca(address);
 
       if (nmg.match(ComboAddress(address))) {
-        return vector<string>{address};
+        return {address};
       } else {
         if (fallback) {
           if (fallback->empty()) {
             // if fallback is an empty string, return an empty array
-            return vector<string>{};
+            return {};
           }
-          return vector<string>{*fallback};
+          return {*fallback};
         }
 
         if (ca.isIPv4()) {
-          return vector<string>{string("0.0.0.0")};
+          return {string("0.0.0.0")};
         } else {
-          return vector<string>{string("::")};
+          return {string("::")};
         }
       }
     });